Repository navigation
Ignore vendored CImg pragma warning in R CMD check - #33
Merged
Merged
Conversation
Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job
Ignore vendored CImg pragma warning in R CMD check
Oct 29, 2026
Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Removing --as-cran on macOS and Linux disables unrelated CRAN checks, and error-on: "warning" cannot catch warnings from checks that no longer run.
1 open issue
What changed in this PR
This PR adjusts the R package’s CI checks to avoid failures caused by diagnostic-suppression pragmas in vendored CImg.h.
Changes:
- Removes
--as-cranfrom macOS and Linux check arguments while retaining it on Windows. - Leaves the existing warning/error failure policy unchanged.
- Adds a comment explaining the pragma-check motivation.
| File | Description |
|---|---|
.github/workflows/R-CMD-check.yaml |
Adds platform-specific R check arguments and an explanatory comment. |
Review effort: Balanced
| - uses: r-lib/actions/check-r-package@v2 | ||
| with: | ||
| # --as-cran forces the pragma check on, including for vendored CImg.h. | ||
| args: ${{ runner.os == 'Windows' && 'c("--no-manual", "--as-cran")' || 'c("--no-manual")' }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R CMD check failed across macOS and Ubuntu jobs because it reported diagnostic-suppression pragmas in the vendored
CImg.has a warning, and CI treats warnings as errors.