Repository navigation
Remove redundant exception handling - #32
Merged
Merged
Conversation
Collaborator
|
¡Gracias Iñaki! We inherited this codebase some time ago, and other than adding or fixing a thing here and there, maintenance has been minimal. This patch looks correct to me, so I'll happily apply it. Thanks also for the tip about FWIW, the test failure is because of an upstream issue with the rlang package, see r-lib/rlang#1887. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exception handling is provided by Rcpp, no need to add another try/catch layer.
(BTW, Rcpp also calls
wrapfor you, soreturn wrap(out)is also redundant)