Skip to content

Fix named-value assertions in coordinate matching tests - #4

Closed
asgr with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-failing-github-actions-job
Closed

asgr with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

The macOS release check failed because testthat compared named bestmatch scalars with unnamed expected values. The named output is intentional; the assertions should compare values independently of names.

  • Regression coverage: Add a focused test for coordmatchsing() selecting the nearest in-radius match.
  • Test setup: Declare testthat and register the package test runner.
  • Assertions: Strip names from extracted scalars before comparison:
    expect_equal(unname(matches$bestmatch["compareID"]), 2)
    expect_equal(unname(matches$bestmatch["sep"]), 0, tolerance = 1e-10)

Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the failing GitHub Actions job macOS-latest (release) Fix named-value assertions in coordinate matching tests Nov 2, 2026
Copilot AI requested a review from asgr November 2, 2026 07:59
@asgr asgr closed this Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants