Repository navigation
Correct Lowlander ranking test expectation - #16
Merged
Merged
Conversation
Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job macOS-latest (release)
Correct Lowlander ranking test expectation
Nov 2, 2026
asgr
marked this pull request as ready for review
November 6, 2026 04:16
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the added regression coverage of likelihood ordering and exclusion of non-finite samples.
No open issues 🎉
What changed in this PR
Adds regression coverage for Lowlander_kept, verifying that minimum-likelihood samples are returned in ascending likelihood order and non-finite samples are excluded.
Changes:
- Adds a fixture expecting
[3,13],[2,12], then[0,10], excluding the sample with infinite likelihood. - Adds the package’s testthat entry point.
| File | Description |
|---|---|
| tests/testthat/test-lowlander-helpers.R | Tests ascending likelihood ranking and exclusion of non-finite samples. |
| tests/testthat.R | Loads testthat and Highlander, then runs the package tests. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
macOS-latest (release)check failed because a test expected minimum-likelihood samples in the wrong order. The helper correctly ranks samples by ascending likelihood.[3,13](likelihood2) before[2,12](likelihood3), with non-finite samples excluded.