Skip to content

Correct Lowlander ranking test expectation - #16

Merged
asgr merged 2 commits into
masterfrom
copilot/fix-macos-latest-release-job
Nov 6, 2026
Merged

asgr merged 2 commits into
masterfrom
copilot/fix-macos-latest-release-job

Conversation

Copilot AI commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

The macOS-latest (release) check failed because a test expected minimum-likelihood samples in the wrong order. The helper correctly ranks samples by ascending likelihood.

  • Regression coverage: Add a test harness and assert the fixture ranks [3,13] (likelihood 2) before [2,12] (likelihood 3), with non-finite samples excluded.
expect_equal(
  Lowlander_kept(result),
  matrix(c(3, 13, 2, 12, 0, 10), ncol = 2, byrow = TRUE)
)

Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job macOS-latest (release) Correct Lowlander ranking test expectation Nov 2, 2026
Copilot AI requested a review from asgr November 2, 2026 08:01
@asgr
asgr marked this pull request as ready for review November 6, 2026 04:16
Copilot AI balanced review requested due to automatic review settings November 6, 2026 04:16
@asgr
asgr merged commit 602b0e7 into master Nov 6, 2026
4 checks passed
@asgr
asgr deleted the copilot/fix-macos-latest-release-job branch November 6, 2026 04:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the added regression coverage of likelihood ordering and exclusion of non-finite samples.

No open issues 🎉

What changed in this PR

Adds regression coverage for Lowlander_kept, verifying that minimum-likelihood samples are returned in ascending likelihood order and non-finite samples are excluded.

Changes:

  • Adds a fixture expecting [3,13], [2,12], then [0,10], excluding the sample with infinite likelihood.
  • Adds the package’s testthat entry point.
File Description
tests/​testthat/​test-lowlander-helpers.R Tests ascending likelihood ranking and exclusion of non-finite samples.
tests/​testthat.R Loads testthat and Highlander, then runs the package tests.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants