Bump hashbrown to 0.17 (MSRV 1.85)#127
Merged
Merged
Conversation
arthurprs
force-pushed
the
hashbrown-0.17
branch
from
dabf235 to
a895f43
Compare
arthurprs
force-pushed
the
switch-foldhash
branch
from
a223f7f to
8217dc2
Compare
hashbrown 0.17 raises its own MSRV to 1.85, so `rust-version` moves to 1.85 to match. The `HashTable` API we use is unchanged — no code changes, and the crate compiles on 1.85 with default, `stats`, and no-default-features.
arthurprs
force-pushed
the
hashbrown-0.17
branch
from
a895f43 to
0102645
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
hashbrownfrom 0.16 to 0.17. hashbrown 0.17 raises its own MSRV to 1.85, so the crate'srust-versionmoves to 1.85 to match.Stacked on #126 (base
switch-foldhash, which is stacked on #124). Merge the lower PRs first.Changes
Cargo.tomlonly — two lines:hashbrown0.16→0.17rust-version1.71→1.85The only hashbrown surface we use is
HashTable(find/find_entry/iter_hash/insert_unique/reserve/allocation_size/with_capacity/iter), and its API is unchanged across the bump — no source changes.MSRV note
This raises the published MSRV from 1.71 to 1.85; consumers on older toolchains can't use this release. CI's
msrvjob verifies againstrust-versioninCargo.toml, so it picks up 1.85 automatically (no workflow edit needed).Verification
Locally with the 1.85.0 toolchain:
cargo +1.85.0 checkcompiles for default features,--features stats, and--no-default-features. On stable:cargo test(56 passed, 1 ignored),cargo clippy,cargo doc -D warnings— all clean.