Repository navigation
Reject multi-qubit arms under controlled(par) - #531
Merged
Merged
Conversation
controlled(par { CNOT @(0, 1) }) @(0, (1, 2)) matched the wire count, so
the typechecker accepted it and elaboration then failed in
controlled_named_gate. Report that same diagnostic at typecheck.
Width-1 arms are unchanged. QASM and NA stay partial. Refs #369.
Co-authored-by: Arnab Ghosh <ag2583@cornell.edu>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Approved. I would merge
Not merging. |
arniber21
marked this pull request as ready for review
October 1, 2026 07:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
controlled(par { CNOT @(0, 1) }) @(0, (1, 2))names three wires, so the typechecker accepted it and elaboration then stopped incontrolled_named_gate(controlled() of a multi-qubit gate).The checker now reports that same diagnostic for a multi-qubit gate in a
pararm (par { … }andpar { c } * k) before placement. Width-1 arms (H @0) are unchanged.QASM and NA stay partial: there is still no
test/litOpenQASM fixture and no neutral-atom fixture. This does not finish the rest of the controlled-pargap.Refs #369.