Repository navigation
Phase 5c: links' Kuma monitors become monitor widgets - #52
Merged
Merged
Conversation
Each link's MonitorId becomes an uptime-kuma/monitor widget, first among its widgets, with the kind's defaults. A link that already has a monitor widget for that monitor (its ID stored as a number or as text) or ten widgets gets none, and without a Kuma connection the IDs are dropped. The ConvertLinkMonitorsToWidgets migration does this, then drops the column; backup format 8 drops links' monitorId and converts older files the same way on import. The tile's badge image, the link dialog's monitor field and the list view's Monitor column go; the list view counts widgets instead. The status bar keeps its badges, the monitor picker and KumaMonitors until 5d. The seed drops its dormant monitor IDs, having no Kuma connection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Links' Uptime Kuma
MonitorIdbadges become h2s's own monitor widgets. Kuma's badge images are gone from tiles, and links no longer need their monitor on a published status page.Migration (
ConvertLinkMonitorsToWidgets)uptime-kuma/monitorwidget, first among its widgets, with the kind's defaults: status, response time, and uptime over the connection's window.Links.MonitorIdcolumn is dropped.Downrestores each link's first monitor widget's ID and keeps the widgets.Backup format 8
monitorId.UseMonitorWidgets), using the file's first Kuma connection.UI
LinkTile.StatusBadgeUrl, the link dialog's monitor field, and themonitorIdhandler parameters and JSON.Kept until 5d: the status bar's badges,
monitor-picker.js,KumaMonitorsandMonitorIdParser, which the infrastructure groups still use. The seed drops its dormant monitor IDs, as it has no Kuma connection.Test plan
DownmonitorIdin exports.ContinuousIntegrationBuild=trueis clean. Two fulljb cleanupcodepasses gave identical results.🤖 Generated with Claude Code