Repository navigation
docs(option_escape_gate): drop the stale README esc count from the module note - #395
Merged
Merged
Conversation
…dule note The module note of the option-template escaping gate cited "`ui/README.md` 五处写「先 `esc()`」" -- "ui/README.md writes 'esc() first' in five places". No reading of that file yields five today: - lines containing `esc(` -> 8 - lines containing `esc()` -> 4 - lines containing `转义` -> 4 - lines containing the literal 「先 `esc()`」 -> 1 (only :161) The number never counted the phrase it names. At `1484311` (#337) -- the commit that wrote this line and created this gate -- the literal phrase appeared once as well. It matches at most the `esc(` line count of that commit's *parent* tree (5), and `1484311` itself raised that count to 8 by adding the R71 section to `ui/README.md`: a snapshot of a quantity its own author keeps raising, i.e. an ownerless count. No test asserts it, so this is the repo's established "drop the number, keep the assertion" fix (cf. `deploy_gate.rs` / `state_gate.rs`, R162/R164/R165). The assertion stays true: `ui/README.md` does write 「先 `esc()`」 (the highlight bullet at :161).
Owner
Author
Self-reviewVerified on the branch (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The module note of
src/option_escape_gate.rs(the option-template escapinggate, R71) claimed:
— "
ui/README.mdwrites 'esc() first' in five places". No reading of thatfile yields five today.
Related Issue
None — a drive-by documentation fix found while auditing doc comments against
today's tree.
Changes
src/option_escape_gate.rs: drop the stale count, keep the assertion —ui/README.md里写着「先esc()」.Census of
ui/README.mdtoday (and at the commit that wrote this line):1484311(#337, wrote this line)esc(esc()转义esc()」:161)So the number never counted the phrase it names. It matches at most the
esc(line count of1484311's parent tree (5) — and1484311itselfraised that count to 8 by adding the R71 section to
ui/README.md. Asnapshot of a quantity its own author keeps raising is an ownerless count,
so the fix is to drop the number rather than refresh it (cf.
deploy_gate.rsand
state_gate.rs, R162/R164/R165). The assertion stays true:ui/README.md:161(the highlight bullet) does write 「先esc()」.Tests
cargo buildcargo test— 557 passed, 0 failedcargo fmt --check— rc 0cargo clippy --all-targets -- -D warnings— rc 0src/*.rsandui/README.mdis untouched).Checklist