Skip to content

fix(ui): transaction table filter row height + drop token column filters - #122

Merged
argszero merged 1 commit into
mainfrom
fix/tx-filter-row-height
Aug 22, 2026
Merged

argszero merged 1 commit into
mainfrom
fix/tx-filter-row-height

Conversation

@argszero

Copy link
Copy Markdown
Owner

Summary

Fix the transaction-table filter row being blown up to ~236px (should be ~48px) by the native <select>'s intrinsic height under table-layout:auto, and — per the host's follow-up — drop the (now-cluttering) min/max filter inputs from the four token columns.

Root cause: .table th had no height constraint and table-layout:auto + border-collapse:collapse lets the <select> in the type/status columns drive the whole row height. The numeric columns used .range-filter{display:flex} (flex ignores intrinsic input height) so they stayed at 47px, while the text/select columns stretched to 236px.

Changes

  • ui/css/style.css — constrain .th-filter / select.th-filter to a fixed height:28px; line-height:1, and vertical-align:top the filter-row cells, so the <select> no longer stretches the auto-layout row. The row now converges to ~44px (fits the 8px cell padding).
  • ui/js/app.js — remove filter:"number-range" from the four token columns (input / cached / output / tokens). Their sort and align:"num" stay; buildDataTable renders an empty <td> for filterless columns, and filterRows already skips columns without col.filter.
  • ui/index.html — cache-bust 20260822-4 → 20260822-5.

Related Rant

This addresses rants (verbatim):

  • 2026-08-22T10:11:48 — "交易记录表筛选行严重换行/撑高(表头高 236px,正常应 ~47px)"
  • 2026-08-22T10:12:57 — "补充:交易记录 token 四列去掉筛选控件(延续 rant 2026-08-22 筛选行 236px 撑高问题)"

Acceptance

  • Transaction-table filter row height drops from 236px to ~48px, consistent with the header.
  • Token columns keep sorting + right-align, but no longer render min/max filter boxes.
  • Filters for time/type/model/key/pts/status are unaffected.
  • 139/139 cargo test + cargo fmt + clippy + node --check (all ui/js/*.js) green.

Tests

  • Existing tests pass (139/139)
  • cargo fmt + clippy clean
  • node --check on all ui/js/*.js

…ers (rants 2026-08-22T10:11:48/10:12:57)

Constrain .th-filter/select.th-filter to a fixed height (28px, line-height:1)
and align filter-row cells to top, so the native select's intrinsic height no
longer stretches the auto-layout row to 236px in the transaction table.

Per host follow-up (10:12:57), remove the number-range filter from the four
token columns (input/cached/output/tokens) — keep their sort and right-align
so the filter row is compact; the time/type/model/key/pts/status filters remain.

Gates: 139/139 cargo test + fmt + clippy + node --check all green.
@argszero
argszero merged commit fcdc069 into main Aug 22, 2026
1 check passed
@argszero
argszero deleted the fix/tx-filter-row-height branch August 22, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant