Repository navigation
fix(ui): transaction table filter row height + drop token column filters - #122
Merged
Merged
Conversation
…ers (rants 2026-08-22T10:11:48/10:12:57) Constrain .th-filter/select.th-filter to a fixed height (28px, line-height:1) and align filter-row cells to top, so the native select's intrinsic height no longer stretches the auto-layout row to 236px in the transaction table. Per host follow-up (10:12:57), remove the number-range filter from the four token columns (input/cached/output/tokens) — keep their sort and right-align so the filter row is compact; the time/type/model/key/pts/status filters remain. Gates: 139/139 cargo test + fmt + clippy + node --check all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the transaction-table filter row being blown up to ~236px (should be ~48px) by the native
<select>'s intrinsic height undertable-layout:auto, and — per the host's follow-up — drop the (now-cluttering) min/max filter inputs from the four token columns.Root cause:
.table thhad no height constraint andtable-layout:auto+border-collapse:collapselets the<select>in the type/status columns drive the whole row height. The numeric columns used.range-filter{display:flex}(flex ignores intrinsic input height) so they stayed at 47px, while the text/select columns stretched to 236px.Changes
ui/css/style.css— constrain.th-filter/select.th-filterto a fixedheight:28px; line-height:1, andvertical-align:topthe filter-row cells, so the<select>no longer stretches the auto-layout row. The row now converges to ~44px (fits the 8px cell padding).ui/js/app.js— removefilter:"number-range"from the four token columns (input/cached/output/tokens). Theirsortandalign:"num"stay;buildDataTablerenders an empty<td>for filterless columns, andfilterRowsalready skips columns withoutcol.filter.ui/index.html— cache-bust20260822-4→20260822-5.Related Rant
This addresses rants (verbatim):
2026-08-22T10:11:48— "交易记录表筛选行严重换行/撑高(表头高 236px,正常应 ~47px)"2026-08-22T10:12:57— "补充:交易记录 token 四列去掉筛选控件(延续 rant 2026-08-22 筛选行 236px 撑高问题)"Acceptance
139/139cargo test +cargo fmt+clippy+node --check(allui/js/*.js) green.Tests