Repository navigation
Conversation
--------- Co-authored-by: Dylan Baker <dylan@pnwbakers.com> Co-authored-by: Jatin Kumar <jatinkumar97511@gmail.com>
Error on depfile writing combined with standard output as outfile is also raised now when using Fypp via the API.
aradi
marked this pull request as ready for review
October 2, 2026 09:07
Owner
Author
|
@dcbaker, @ijatinydv: I am finished with the additional changes. I plan to merge it next week and them make a release. If you can give the current version a try, I'd welcome feedback about any issues you encounter. |
dcbaker
approved these changes
Oct 2, 2026
dcbaker
left a comment
dcbaker
left a comment
Contributor
There was a problem hiding this comment.
I won't have a chance to test this anytime soon (I'm swamped at work and don't have a ton of time for buildsystem stuff ATM), but I looked at your changes and they look good.
Thanks again to both of you for picking up and seeing this to the end.
Owner
Author
|
Sure, no problem. Thanks for initiating the feature. I'll merge it to main then. |
aradi
added a commit
that referenced
this pull request
Oct 2, 2026
--------- Co-authored-by: Dylan Baker <dylan@pnwbakers.com> Co-authored-by: Jatin Kumar <jatinkumar97511@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseeds #41 and #64, is based on the refactored main.
Adapting the code / suggestions by @dcbaker and @ijatinydv but based on the current main (which had been somewhat refactored in the mean time). Original authors had been added as co-authors.