test(server): run embedded MongoDB natively on Apple Silicon - #42275
wyattwalter wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: appsmithorg/appsmith/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe server test setup now uses Flapdoodle 4.33.0 and MongoDB 7.0.34. New tests check platform package URLs, embedded server and replica-set properties, and transaction outcomes. Server setup documentation describes the configuration and test command. ChangesEmbedded MongoDB tests
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is established. The change is ready for normal test validation before merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Mongo starts with versions pinned tight, Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Description
Server JUnit tests download Intel-only MongoDB 5.0.5 on Apple Silicon, so running tests through an IDE or coding agent triggers macOS Rosetta deprecation warnings. Pin embedded MongoDB to 7.0.34 and align the test-only Flapdoodle dependencies at 4.33.0, using the Spring 3.x integration. The resolver selects native packages automatically; 7.0.34 is the newest MongoDB 7 release listed in this compatible resolver.
Add regression coverage for macOS ARM64/x86_64, Ubuntu 22.04 ARM64/x86_64, and Windows x86_64 package selection. A live Spring/Flapdoodle test checks the launched server's architecture, configured version, replica-set readiness, and transaction commit/abort. Document the standalone smoke-test command.
Fixes https://linear.app/appsmith/issue/APP-16017
Testing
x86_64on an ARM64 JVM. Restoring the new pins gives 7/7 passing tests.mongodverified asMach-O 64-bit executable arm64.602d392e17dffacb4e98792275a94a0f09226f3e: quality checks, Cypress.Completeness: checked both CE/EE version pins and dependencies, the shared
TransactionalConfigreplica-set arguments, existing MongoDB-backed repository tests, and server setup documentation. Datasource-plugin MongoDB tests use Testcontainers and do not use this embedded binary. Production Docker/Helm MongoDB settings are unchanged.Impact on existing instances
The first test run downloads the native archive. Old cached archives can coexist; deleting the cache is unnecessary. Apple Silicon test execution requires an ARM64 JDK.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Communication
Should the DevRel and Marketing teams inform users about this change?
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/35871157120
Commit: 602d392
Cypress dashboard.
Tags:
@tag.AllSpec:
Wed, 23 Sep 2026 14:50:42 UTC
Summary by CodeRabbit