Deploy postgres/redis alerts as subcharts#1277
Draft
samiulsami wants to merge 2 commits into
Draft
Conversation
samiulsami
force-pushed
the
alerts-as-subcharts
branch
from
2233363 to
1178ac0
Compare
Signed-off-by: sami <sami@appscode.com>
samiulsami
force-pushed
the
alerts-as-subcharts
branch
from
bfb56ab to
c0c207e
Compare
ArnobKumarSaha
requested changes
Jun 17, 2026
Comment on lines
+104
to
+106
| groups: | ||
| stash: | ||
| enabled: "" |
Member
Author
There was a problem hiding this comment.
To disable the legacy stash alerts (the hardcoded alerts excluded them as well)
Member
There was a problem hiding this comment.
https://github.com/opnpulse/alerts/blob/master/apis/alerts/v1alpha1/types.go#L79
But this supports only string value.
.
We cant control some string value with a boolean.
Plus, the stash alerts will still be there in the promRule. How will you disable that ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it easier to propagate alert rule changes from the alerts chart(s) instead of hardcoding them here.
requires: opnpulse/alerts#128