Enable .closeOnExec for FileDescriptor.open on Windows#331
Open
jakepetroules wants to merge 1 commit into
Open
Enable .closeOnExec for FileDescriptor.open on Windows#331jakepetroules wants to merge 1 commit into
jakepetroules wants to merge 1 commit into
Conversation
Make OpenOptions.closeOnExec available on Windows, where it maps to _O_CLOEXEC (O_NOINHERIT). The Windows open adapter already decodes O_NOINHERIT into a non-inheritable handle, so this produces the expected close-on-exec semantics. Also add the deprecated O_NOINHERIT alias, matching the PipeOptions treatment from #312.
jakepetroules
requested review from
glessard,
lorentey and
milseman
as code owners
Member
Author
|
@swift-ci test |
grynspan
reviewed
Jun 29, 2026
| @@ -319,6 +318,11 @@ extension FileDescriptor { | |||
| @_alwaysEmitIntoClient | |||
| @available(*, unavailable, renamed: "closeOnExec") | |||
| public static var O_CLOEXEC: OpenOptions { closeOnExec } | |||
There was a problem hiding this comment.
Should probably still be !Windows here.
Member
Author
There was a problem hiding this comment.
I'm just staying consistent with what PipeOptions is doing.
There was a problem hiding this comment.
I think that's just a typo in PipeOptions that we didn't catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make OpenOptions.closeOnExec available on Windows, where it maps to _O_CLOEXEC (O_NOINHERIT). The Windows open adapter already decodes O_NOINHERIT into a non-inheritable handle, so this produces the expected close-on-exec semantics. Also add the deprecated O_NOINHERIT alias, matching the PipeOptions treatment from #312.