Switch lsp to native - #108
Open
stackoverflow wants to merge 2 commits into
Open
stackoverflow wants to merge 2 commits into
stackoverflow wants to merge 2 commits into
Conversation
stackoverflow
commented
Sep 24, 2026
|
|
||
| export const LSP_GITHUB_REPO = "apple/pkl-lsp"; | ||
|
|
||
| export const LSP_INSTALLATION_DOCS_URL = "https://pkl-lang.org/lsp/current/installation.html"; |
Contributor
Author
There was a problem hiding this comment.
This link doesn't exist yet, so it needs to be validated before merging.
HT154
approved these changes
Sep 24, 2026
HT154
left a comment
HT154
left a comment
Contributor
There was a problem hiding this comment.
LGTM on inspection, approving to unblock once an LSP release is cut, just a couple nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the bundling of pkl-lsp with the distributed pkl-vscode.
It also switches the old pkl-lsp jar support with the new binary distribution which is not yet released.
This PR should only be merged after we release the new pkl-lsp version, so proper tests can be done.