Restrict which commands the LSP may run - #105
Conversation
| "type": "string", | ||
| "default": null, | ||
| "description": "Path to pkl executable", | ||
| "scope": "Pkl" |
There was a problem hiding this comment.
This is an unrelated bugfix. "Pkl" is not a valid scope.
There was a problem hiding this comment.
Can we move this into a separate PR?
This would be a breaking change for some clients (e.g. pkl-lsp queries for configuration values with "Pkl" set as its scope). Also, we have a bunch more config values that use "scope": "Pkl"
There was a problem hiding this comment.
Reverted because it's unrelated to this pr.
This would be a breaking change for some clients
Where did you get this idea? scope is a closed enum (https://code.visualstudio.com/api/references/contribution-points#contributes.configuration scope header). Pkl is not a valid value, so vscode is ignoring the value here. There's nothing to break.
Also, we have a bunch more config values that use "scope": "Pkl"
Can you point where? I didn't find any other place with a Pkl scope.
There was a problem hiding this comment.
Oh, huh, you're right; I thought we did.
Also: here's the code that needs to change in pkl-lsp: https://github.com/apple/pkl-lsp/blob/main/src/main/kotlin/org/pkl/lsp/services/SettingsManager.kt#L142
ad40b05 to
d67ac74
Compare
3 participants
No description provided.