refactor: Gsm extension to remove legacy fallback logic#1225
Merged
KazuCocoa merged 2 commits intoappium:masterfrom May 6, 2026
Merged
refactor: Gsm extension to remove legacy fallback logic#1225KazuCocoa merged 2 commits intoappium:masterfrom
KazuCocoa merged 2 commits intoappium:masterfrom
Conversation
Removed legacy command execution fallbacks in the Gsm extension for Android. The methods make_gsm_call, set_gsm_signal, and set_gsm_voice now use execute_script with the 'mobile:' prefix directly. - Removed UnknownMethodException and CanRememberExtensionPresence imports. - Updated Gsm class to no longer inherit from CanRememberExtensionPresence. - Simplified extension methods by removing try-except blocks. - Emptied _add_commands method as legacy endpoints are no longer needed.
KazuCocoa
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the
Gsmextension inappium/webdriver/extensions/android/gsm.pyby removing legacy fallback logic and related dependencies. The code now relies solely on the modern extension script execution path, improving maintainability and clarity.Dependency and code cleanup:
CanRememberExtensionPresence,UnknownMethodException, andCommand, as the legacy fallback logic is no longer needed. [1] [2]Simplification of GSM command methods:
make_gsm_call,set_gsm_signal, andset_gsm_voicemethods to remove fallback logic—these methods now only useexecute_scriptfor extension calls. [1] [2] [3]_add_commandsmethod is now a no-op (pass), since custom commands are no longer registered.