Repository navigation
Let a driver own app state, debug logging and activation on xctest runs - #17
Merged
Merged
Conversation
Author
|
Supersedes the original work, reimplemented on current upstream:
Same three options, same defaults; the two follow-up fixups on the original branches are folded in rather than carried as separate commits. |
Three options for a caller that manages the device itself: keep running applications alive, drop the runner's _XCT_logDebugMessage traffic, and pass activate_suspended to the test host. All three default to the existing behaviour. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
rubu
force-pushed
the
sync/03-xctest-options
branch
from
September 28, 2026 15:31
0d8f3d1 to
0a9541b
Compare
rubu
force-pushed
the
sync/02-eject-button
branch
from
September 28, 2026 15:31
4fd7639 to
5d66beb
Compare
weiyin
approved these changes
Sep 28, 2026
Author
|
We might be able to drop this as well, but i'm not sure if we will need the xctest mode until we fully transition to Xcode 27 and after that we can revert this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three options on
XctestRunRequest, for a caller that manages the device itself rather than letting the test run manage it:kill_all_running_applications— keep running apps alive instead of killing them before the test host launchesdisable_xctest_debug_logging— drop the runner's_XCT_logDebugMessagetraffic rather than logging itactivate_suspended— passed through to the test host's launch optionsAll three default to the existing behaviour, so a caller that sets none of them sees no change.
Stacked on #16.
🤖 Generated with Claude Code