fix(redis): Prevent counter corruption from concurrent mark handled in Redis RQ#1878
Merged
vdusek merged 1 commit intoapify:masterfrom May 7, 2026
Merged
Conversation
…uest_as_handled calls for the same request
RedisRequestQueueClient.mark_request_as_handled calls for the same request
janbuchar
reviewed
May 7, 2026
Comment on lines
+439
to
+440
| # If we fail to mark the request as handled after removing it from in_progress, we restore request in | ||
| # `in_progress` hash. |
Collaborator
There was a problem hiding this comment.
And that will result in a retry, correct?
Collaborator
Author
There was a problem hiding this comment.
Yes, if it's a Redis-related error, it will trigger a retry using @retry_on_error(RedisError).
If something unexpected happens, the error will be propagated.
janbuchar
approved these changes
May 7, 2026
vdusek
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mark_request_as_handledcalls for the same request. When two coroutines concurrently calledmark_request_as_handledfor the same request, both could pass thehexistscheck before either executed the pipeline, causing counters to be updated multiple times for the same request, breaking the queue operation.Issues
Testing
in_progressafter failure.Checklist