fix(workflow-operator): default boolean metadata fields#5177
Merged
Yicong-Huang merged 1 commit intoMay 25, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5177 +/- ##
============================================
+ Coverage 43.65% 46.26% +2.61%
- Complexity 2219 2369 +150
============================================
Files 1049 1049
Lines 40572 40572
Branches 4324 4324
============================================
+ Hits 17713 18772 +1059
+ Misses 21767 20657 -1110
- Partials 1092 1143 +51
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yicong-Huang
approved these changes
May 25, 2026
Contributor
Yicong-Huang
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Some operator boolean properties initialized to
falsedid not declare a JSON-schema default value, so the frontend form could render them as neutral checkboxes instead of unchecked checkboxes.This PR adds explicit
defaultValue = "false"metadata for:FilledAreaPlotOpDesc.facetColumnDumbbellPlotOpDesc.showLegendsJSONLScanSourceOpDesc.flattenIt also adds a focused metadata-generation spec that asserts these boolean schemas include a
falsedefault.Any related issues, documentation, discussions?
Closes #4015.
How was this PR tested?
Validated locally with a temporary Postgres container loaded with the same DDL files used by CI for JOOQ generation.
Result: 2 passed.
Result: passed.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)