fix(#4891): restore icon spacing in Material buttons - #4892
Open
tenthe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Icons inside Angular Material buttons were written as raw
<i class="material-icons">. Material's spacing and sizing rules are scoped to.mat-icon, so those buttons got neither the 8px gap nor the1.125remsize clamp. This PR converts them to<mat-icon>and removes the manual spacers added to compensate.Changes
<mat-icon>, addingMatIconto the 30 components that lacked it. spacers that would otherwise stack on the restored margin.gapand icon size.Remarks
PR introduces (a) breaking change(s): yes
PR introduces (a) deprecation(s): yes