[SPARK-58021][CONNECT] Add local server pool acquisition engine - #57687
Open
ericm-db wants to merge 4 commits into
Open
[SPARK-58021][CONNECT] Add local server pool acquisition engine#57687ericm-db wants to merge 4 commits into
ericm-db wants to merge 4 commits into
Conversation
Expose the per-user runtime directory and startup seed configuration, and let LocalConnectServer start isolated daemons with an ephemeral port and precomputed configuration. Keep persistent-server reuse on the same launch path and add focused unit coverage.
Co-authored-by: Isaac Claude-Session: https://claude.ai/code/session_011tpdLYqY4VRw4s1KjDb2fi
Co-authored-by: Isaac Claude-Session: https://claude.ai/code/session_011tpdLYqY4VRw4s1KjDb2fi
Co-authored-by: Isaac Claude-Session: https://claude.ai/code/session_011tpdLYqY4VRw4s1KjDb2fi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is layer 4 of the local Connect pool stack: #57684 -> #57685 -> #57686 -> this PR. Until the lower layers merge, GitHub shows their cumulative diff; the new review unit here is commit
f3a02502293.This layer adds the acquisition engine:
--attendplus user-invoked--purgeentry points.SparkSession integration and JIT warmup remain in later PRs.
Why are the changes needed?
The storage and lifecycle layers define safe state transitions, but a pool also needs one owner for launching and supervising each server. Isolating that orchestration makes the attendant boundary, environment sanitization, retry behavior, and refill concurrency independently reviewable.
Does this PR introduce any user-facing change?
No. The acquisition engine is not selected by SparkSession in this layer.
How was this patch tested?
Expanded
LocalConnectServerPoolUnitTestswith acquisition coverage for fingerprint-aware refill, re-entrant acquisition of an existing claim, and the POSIX platform gate, in addition to all storage and lifecycle cases.All 17 tests passed. Ruff check, Ruff format check, and
git diff --checkalso passed.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Fable 5) and OpenAI Codex (GPT-5)