[SPARK-58471][ML][CONNECT] Improve TrainValidationSplitModel size estimation - #57674
Draft
zhengruifeng wants to merge 1 commit into
Draft
[SPARK-58471][ML][CONNECT] Improve TrainValidationSplitModel size estimation#57674zhengruifeng wants to merge 1 commit into
zhengruifeng wants to merge 1 commit into
Conversation
zhengruifeng
changed the title
zhengruifeng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This subtask of SPARK-58181, and follow-up to #57665, applies parameter-aware size estimation to
TrainValidationSplitModel.It excludes the
estimator,estimatorParamMaps, andevaluatorparams from metadata sizing, then explicitly accounts for the best model, validation metrics, and collected submodels. A regression test confirms that logger-initialized estimator state is not counted.Why are the changes needed?
TrainValidationSplitModel retains the same kinds of tuning params as CrossValidatorModel. Their params and values may retain shared runtime state, such as SparkSession, which must not contribute to Spark Connect ML model-cache accounting.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Static checks:
git diff --check, non-ASCII scan, and changed-Scala line-length scan.The targeted Scala suite was not run locally.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex GPT-5