[SPARK-58470][PS] Use native expressions for NumPy trunc - #57673
Draft
zhengruifeng wants to merge 2 commits into
Draft
[SPARK-58470][PS] Use native expressions for NumPy trunc#57673zhengruifeng wants to merge 2 commits into
zhengruifeng wants to merge 2 commits into
Conversation
zhengruifeng
marked this pull request as draft
July 31, 2026 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace the pandas UDF mapping for NumPy trunc on pandas-on-Spark objects with native Spark expressions. The implementation uses the remainder of the absolute double value and reapplies the sign, preserving nulls, NaN, infinities, and signed zero. Add coverage for these values and fractional positive and negative inputs.
Why are the changes needed?
Spark does not provide a numeric trunc function, but the operation can be evaluated with native expressions without crossing the Python worker boundary.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
NumPyCompatTests.test_np_math_functions.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)