Skip to content

QPIDJMS-616: enhance error message to include additional info from errorCondition #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vm-karthik wants to merge 2 commits into
base: main
Choose a base branch
from
Open

QPIDJMS-616: enhance error message to include additional info from errorCondition #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9d742d
QPIDJMS-616: enhance error message to include additional info from er…
vm-karthik Nov 7, 2025
03ac2ef
more change
vm-karthik Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,18 @@ public static String extractErrorMessage(ErrorCondition errorCondition) {
if (condition != null) {
message = message + " [condition = " + condition + "]";
}

try {
Map<?, ?> info = errorCondition.getInfo();
String messageWithInfo = message;
if (info != null && !info.isEmpty()) {
messageWithInfo = message + " [info = " + info + "]";
}
return messageWithInfo;

@Claudenw Claudenw Jun 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance that the map returned by the errorCondition.getInfo() contains privileged information? Specifically contents of something read from disk or unobfuscated passwords or access tokens or similar?

@gemmellr gemmellr Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldnt expect that, but its up to the peer to decide what they put in there so its impossible to say what might be in there. Typically nothing, hence whey no client I know of thus far does whats proposed.

}
catch (Exception e) {
return message;
}
}

return message;
Expand Down