Skip to content

Restore java_value fallbacks lost in the switch reordering #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjfanning merged 1 commit into from
Aug 31, 2026
+8 −8
Merged

Restore java_value fallbacks lost in the switch reordering #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/main/java/org/apache/xmlbeans/impl/values/XmlObjectBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3081,9 +3081,10 @@ protected static Object java_value(XmlObject obj) {

case SchemaType.SIZE_BIG_DECIMAL:
return base.getBigDecimalValue();

default:
assert (false) : "invalid numeric bit count";
// fallthrough
return base.getBigDecimalValue();
}
}
case SchemaType.BTC_ANY_URI:
Expand All @@ -3101,19 +3102,18 @@ protected static Object java_value(XmlObject obj) {
case SchemaType.BTC_G_DAY:
case SchemaType.BTC_G_MONTH:
return base.getCalendarValue();
case SchemaType.BTC_NOTATION:

// NB: for string enums we just do java.lang.String
// when in the context of unions. It's easier on users.
case SchemaType.BTC_NOTATION:
case SchemaType.BTC_STRING:
case SchemaType.BTC_ANY_SIMPLE:
// return base.getStringValue();
return base.getStringValue();

default:
assert (false) : "encountered nonprimitive type.";
// fallthrough

// NB: for string enums we just do java.lang.String
// when in the context of unions. It's easier on users.
return base.getStringValue();
}
return null;
}

/**
Expand Down
Loading