Update sbt-mima-plugin to 1.2.1 - #3558
Merged
pjfanning merged 2 commits intoSep 24, 2026
Merged
Conversation
Motivation: sbt-mima-plugin 1.2.1 reports definitions that were public in 1.0.0 but are now private[pekko] or sealed as ClassNoLongerCheckedProblem, MethodNoLongerCheckedProblem or HierarchyNoLongerCheckedProblem, because it stops watching them even though the bytecode stays public. The Check / Binary Compatibility job failed on actor, stream, remote, cluster-sharding and cluster-sharding-typed with 29 such reports. Modification: Add a src/main/mima-filters/binary-api file to each of the five modules with the BinaryApi.keep entries the report suggested. This keeps MiMa checking those definitions instead of silencing them with ProblemFilters, so a later removal is still reported against clients compiled against 1.0.x. Result: mimaReportBinaryIssues passes with sbt-mima-plugin 1.2.1 and the narrowed definitions remain under binary compatibility checking. Tests: - Not run locally; the 29 entries are the lines suggested by the failing Check / Binary Compatibility job, verified by diff. CI re-runs the check. References: None - follow-up for the sbt-mima-plugin 1.2.1 bump in this PR
pjfanning
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this PR
📦 Updates com.typesafe:sbt-mima-plugin from
1.2.0to1.2.1📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
🔍 Files still referring to the old version number
The following files still refer to the old version number (1.2.0).
You might want to review and update them manually.
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: