Skip to content

test: make RemotingSpec bind retry match the classic Netty BindException #3551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pjfanning wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: make RemotingSpec bind retry match the classic Netty BindException #3551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions remote/src/test/scala/org/apache/pekko/remote/classic/RemotingSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@
package org.apache.pekko.remote.classic

import java.io.NotSerializableException
import java.net.{ BindException, InetAddress, ServerSocket }
import java.util.concurrent.ThreadLocalRandom

import scala.annotation.nowarn
import scala.annotation.{ nowarn, tailrec }
import scala.concurrent.{ Await, Future }
import scala.concurrent.duration._
import scala.util.control.NonFatal
Expand Down Expand Up @@ -966,6 +967,17 @@ class RemotingSpec extends PekkoSpec(RemotingSpec.cfg) with ImplicitSender with

}

// classic Netty rethrows the raw java.net.BindException from ActorSystem startup, so look for it in
// the cause chain rather than relying on the message text
@tailrec
def isBindFailure(t: Throwable): Boolean =
t match {
case null => false
case _: BindException => true
case _ if t.getMessage != null && t.getMessage.contains("Failed to bind") => true
case _ => isBindFailure(t.getCause)
}

// retry a few times as the temporaryServerAddress can be taken by the time the new actor system
// binds
def selectionAndBind(
Expand All @@ -984,13 +996,29 @@ class RemotingSpec extends PekkoSpec(RemotingSpec.cfg) with ImplicitSender with
try {
(ActorSystem("other-system", otherConfig), otherSelection)
} catch {
case NonFatal(ex) if ex.getMessage.contains("Failed to bind") && retries > 0 =>
case NonFatal(ex) if isBindFailure(ex) && retries > 0 =>
selectionAndBind(config, thisSystem, probe, retries = retries - 1)
case other =>
throw other
}
}

"recognize a bind failure when the configured port is already taken" in {
val taken = new ServerSocket(0, 1, InetAddress.getByName("localhost"))
try {
val config = ConfigFactory.parseString(s"""
pekko.remote.classic.enabled-transports = ["pekko.remote.classic.netty.tcp"]
pekko.remote.classic.netty.tcp.port = ${taken.getLocalPort}
""").withFallback(remoteSystem.settings.config)
val ex = intercept[Exception] {
val sys = ActorSystem("taken-port-system", config)
shutdown(sys)
}
isBindFailure(ex) shouldBe true
isBindFailure(new IllegalStateException("something else")) shouldBe false
} finally taken.close()
}

"be able to connect to system even if it's not there at first" in {
val config = ConfigFactory.parseString(s"""
pekko.remote.classic.enabled-transports = ["pekko.remote.classic.netty.tcp"]
Expand Down
Loading