Skip to content

SSE: allow Unicode line terminators (#1185) #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjfanning merged 1 commit into from
Jul 27, 2026
Merged

SSE: allow Unicode line terminators (#1185) #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ...st/scala/org/apache/pekko/http/scaladsl/unmarshalling/sse/ServerSentEventParserSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,27 @@ final class ServerSentEventParserSpec extends AsyncWordSpec with Matchers with B
ServerSentEvent("event 3", None, Some("")),
ServerSentEvent("event 4")))
}
"parse data values containing Unicode line terminators (U+0085, U+2028, U+2029)" in {
// WHATWG SSE spec: lines end only on CR/LF/CRLF; these Unicode chars are ordinary content
val nel = "\u0085" // NEL
val ls = "\u2028" // LINE SEPARATOR
val ps = "\u2029" // PARAGRAPH SEPARATOR
val input = Vector(
s"data: before${nel}after",
"",
s"data: before${ls}after",
"",
s"data: before${ps}after",
"")
Source(input)
.via(new ServerSentEventParser(1048576, emitEmptyEvents = false))
.runWith(Sink.seq)
.map(
_ shouldBe Vector(
ServerSentEvent(s"before${nel}after"),
ServerSentEvent(s"before${ls}after"),
ServerSentEvent(s"before${ps}after")))
}
"parse ServerSentEvents correctly (and pass empty events)" in {
val input = """|data: event 1 line 1
|data:event 1 line 2
Expand Down
2 changes: 1 addition & 1 deletion ...c/main/scala/org/apache/pekko/http/scaladsl/unmarshalling/sse/ServerSentEventParser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ private object ServerSentEventParser {

private final val Retry = "retry"

private val Field = """([^:]+): ?(.*)""".r
private val Field = """(?s)([^:]+): ?(.*)""".r
}

case class OversizedSseEvent(event: ServerSentEvent)
Expand Down
Loading