Skip to content

refactor COSWriterCompressionPool.filterElement method #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valerybokov wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

refactor COSWriterCompressionPool.filterElement method #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/compress/COSWriterCompressionPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,20 +246,20 @@ private boolean filterElement(COSBase element)
if (element instanceof COSObject)
{
COSObject cosObject = (COSObject) element;
if (cosObject.getKey() != null && objectPool.contains(cosObject.getKey()))
COSObjectKey objectKey = cosObject.getKey();
COSBase object = cosObject.getObject();
if (objectKey != null && objectPool.contains(objectKey))
{
// check if the stored object matches the referenced object otherwise replace the key with a new one
// there may differences if some imported content uses the same object numbers than the target pdf
if (objectPool.getObject(cosObject.getKey()).equals(cosObject.getObject()))
if (objectPool.getObject(objectKey).equals(object))
{
return false;
}
cosObject.setKey(null);
}
if (cosObject.getObject() != null)
{
return true;
}

return object != null;
}
else if (element instanceof COSArray
|| (element instanceof COSDictionary && !allDirectObjects.contains(element)))
Expand Down