Skip to content

[core] Fix silent data corruption due to overflow in FieldProductAgg#7906

Open
ArnavBalyan wants to merge 1 commit into
apache:masterfrom
ArnavBalyan:arnavb/fix-product-overflow
Open

[core] Fix silent data corruption due to overflow in FieldProductAgg#7906
ArnavBalyan wants to merge 1 commit into
apache:masterfrom
ArnavBalyan:arnavb/fix-product-overflow

Conversation

@ArnavBalyan
Copy link
Copy Markdown
Member

@ArnavBalyan ArnavBalyan commented May 19, 2026

Purpose

  • FieldProductAgg multiplies integers without overflow detection.
  • Accumulator silently wraps corrupting downstream product aggregations.
  • Throw on overflow using Math multiplyExact and range checks.

Tests

  • UT

@ArnavBalyan
Copy link
Copy Markdown
Member Author

cc @JingsongLi thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant