[spark] Introduce plan-auto-tag-for-read for Spark read#7897
Merged
Conversation
| public void deleteReadTag(String tagName) { | ||
| try { | ||
| if (tagManager.tagExists(tagName)) { | ||
| snapshotManager.fileIO().deleteQuietly(tagManager.tagPath(tagName)); |
Contributor
There was a problem hiding this comment.
Is this intentionally deleting only the tag meta file instead of calling table.deleteTag(tagName) to
keep read cleanup lightweight
Contributor
Author
There was a problem hiding this comment.
Directly delete the tag metadata file instead of using TagManager.deleteTag(), which would also scan and delete unreferenced data files — too heavyweight for a read-path cleanup. Any orphan data files left behind will be reclaimed by OrphanFilesClean.
Commented in 1d4a461
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce
'scan.plan-auto-tag-for-read.time-retained'option:When set, a temporary tag will be auto-created during batch scan planning to protect the read snapshot from expiration. The value specifies the tag's TTL. Should be longer than the longest expected batch read duration.
Tests