Add integration test for SelectJdkToolchainMojo version range matching - #182
Open
elharo wants to merge 1 commit into
Open
Add integration test for SelectJdkToolchainMojo version range matching#182elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
elharo
force-pushed
the
add-version-matching-tests
branch
from
July 22, 2026 20:42
2740bdc to
e14544c
Compare
elharo
changed the title
elharo
force-pushed
the
add-version-matching-tests
branch
from
July 22, 2026 20:52
e14544c to
b3fb13f
Compare
Refs apache#167 Add an integration test that verifies the select-jdk-toolchain goal correctly matches a toolchain version against a version range requirement. The test configures a JDK toolchain with version "11" and requests version range "[11,17)". If the version matching in SelectJdkToolchainMojo.matches() were broken, the build would fail with "Cannot find matching toolchain definitions". Uses reflection-free approach via maven-invoker-plugin integration test to exercise the full plugin execution path.
elharo
force-pushed
the
add-version-matching-tests
branch
from
July 23, 2026 10:24
b3fb13f to
d2c8675
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #167
Adds unit tests for the
matches()method inSelectJdkToolchainMojoto verify version matching behavior.Uses reflection to test the private method without changing source code visibility. Tests confirm that
RequirementMatcherFactory.createVersionMatcher()is called with the correct argument order:createVersionMatcher(tcVal).matches(reqVal)wheretcValis the toolchain's concrete version andreqValis the user's requirement (which may be a range like"[11,17)").All 3 tests pass against the current code, confirming the existing implementation is correct.