Skip to content

Use Maven 3.10.0-rc-1 for integration tests verification #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slawekjaranowski wants to merge 2 commits into
base: maven-3.10.x
Choose a base branch
from
+5 −2
Open

Use Maven 3.10.0-rc-1 for integration tests verification #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7822358
Use Maven 3.10.0-rc-1 for integration tests verification
slawekjaranowski Jul 28, 2026
7bc1bf9
Fix for version pattern matching like 3.10.0-rc-1
slawekjaranowski Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven-verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
cache: 'maven'

- name: Set up Maven
run: mvn --errors --batch-mode --show-version org.apache.maven.plugins:maven-wrapper-plugin:3.3.4:wrapper "-Dmaven=3.9.12"
run: mvn --errors --batch-mode --show-version org.apache.maven.plugins:maven-wrapper-plugin:3.3.4:wrapper "-Dmaven=3.10.0-rc-1"
shell: bash

- name: Running integration tests
Expand Down
3 changes: 2 additions & 1 deletion ...t/maven-it-helper/src/main/java/org/apache/maven/it/AbstractMavenIntegrationTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ public abstract class AbstractMavenIntegrationTestCase {

private String testName;

private static final Pattern DEFAULT_MATCH_PATTERN = Pattern.compile("(.*?)-(RC[0-9]+|SNAPSHOT|RC[0-9]+-SNAPSHOT)");
private static final Pattern DEFAULT_MATCH_PATTERN =
Pattern.compile("(.*?)-([Rr][Cc]-?[0-9]+|SNAPSHOT|[Rr][Cc]-?[0-9]+-SNAPSHOT)");

protected static final String ALL_MAVEN_VERSIONS = "[2.0,)";

Expand Down
2 changes: 2 additions & 0 deletions ...pport/maven-it-helper/src/test/java/org/apache/maven/it/MavenIntegrationTestCaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ public void testRemovePatternForTestWithVersionRange() {
assertVersionEquals("2.0.10", "2.0.10-SNAPSHOT", test);
assertVersionEquals("2.0.10", "2.0.10-RC1", test);
assertVersionEquals("2.0.10", "2.0.10-RC1-SNAPSHOT", test);
assertVersionEquals("3.10.0", "3.10.0-RC-1", test);
assertVersionEquals("3.10.0", "3.10.0-rc-1", test);
}

private static void assertVersionEquals(String expected, String version, AbstractMavenIntegrationTestCase test) {
Expand Down