Remove deprecated setCompilerVersion() call - #1088
Open
elharo wants to merge 1 commit into
Open
Conversation
CompilerConfiguration.setCompilerVersion() is deprecated and no longer evaluated by the underlying compilers. The compilerVersion field is already @deprecated; remove the no-op call to eliminate the deprecation warning while keeping the field for backward compatibility.
There was a problem hiding this comment.
Pull request overview
This PR removes a deprecated, no-op call to CompilerConfiguration.setCompilerVersion() from AbstractCompilerMojo.executeReal(), eliminating a deprecation warning while keeping the deprecated compilerVersion parameter for backward compatibility with existing user configurations.
Changes:
- Removed the
compilerConfiguration.setCompilerVersion(compilerVersion);call during compiler configuration setup. - Kept the deprecated
compilerVersionMaven parameter intact so users still receive a deprecation warning (without breaking builds).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompilerConfiguration.setCompilerVersion()is deprecated and no longer evaluated by the underlying compilers. ThecompilerVersionfield inAbstractCompilerMojois already@Deprecatedwith this Javadoc:This removes the no-op call to eliminate the deprecation warning while keeping the
@Deprecatedfield for backward compatibility — users who still setmaven.compiler.compilerVersionwill get a deprecation warning but not a build error."