test(desktop): settle prompt-rail scroll jumps - #3863
Closed
liugddx wants to merge 1 commit into
Closed
Conversation
Generated-by: Codex
Member
Author
|
@Astro-Han Hosted exact-head est is green, including the full Desktop e2e suite. The change only reuses the spec's existing scroll notification and painted-frame helpers; all exact tail-mount, eviction, focus, and selection assertions remain unchanged. Please review when available. |
8 tasks
6 tasks
Astro-Han
reviewed
Aug 26, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
I reviewed this head and found no blocking issues.
Adds notifyTranscriptScrolled after scrollTranscriptTo to ensure virtualizer observes programmatic scroll; hosted test: SUCCESS (32932185830).
No P0-P3.
简体中文
该头无阻断。Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make prompt-rail test scrolling deterministic for the turn virtualizer.
scrollTop;Why
scrollTranscriptTopreviously only assignedscrollTop. A programmatic assignment did not provide a deterministic observation/paint boundary for the virtualizer, so the eviction scenario could wait ten seconds forturn-prompt-rail-120while the mounted window remained stale.This reproduced on an unrelated #3789 head in run 32930874507. That PR has no Desktop/UI diff.
The spec already used
notifyTranscriptScrolledandwaitForPaintedFrameslater in the same eviction journey. This change moves that existing boundary into the shared scroll helper so every top/bottom setup has deterministic semantics.Verification
npm run lintnpm run format:checknpx knip --workspace apps/desktopgit diff --checkThe local Windows full build currently reproduces unrelated current-main Runtime Host type failures, while the exact
mainpush CI is green. The authoritative Desktop e2e evidence for this test-only change is therefore the hosted Linux/xvfbtestcheck on this PR.AI use
Tool and scope: Codex analyzed the hosted trace, reused the spec's existing scroll notification and paint helpers, and ran the listed local gates.
Fixes #3862.
Checklist
testpasses on exact head52e9a6024, including the full Desktop e2e suiteDoes this PR entail a change in behavior?