Skip to content

refactor(runtime-host): unify local deployment handoffs #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Aug 26, 2026
Merged

refactor(runtime-host): unify local deployment handoffs #3813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 67 additions & 24 deletions packages/runtime-host/src/__tests__/local-deployment-owner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ test('removes abandoned record workspaces before applying the next transition',
assert.equal(entries.includes(unrelated), true);
});

test('persists transfer intent before cutover and commits the exact target', async (t) => {
test('persists handoff intent before cutover and commits the exact target', async (t) => {
const options = await authority(t);
const claimed = await applyLocalHostDeploymentTransition(
ROOT_ID,
Expand All @@ -323,7 +323,7 @@ test('persists transfer intent before cutover and commits the exact target', asy
const begun = await applyLocalHostDeploymentTransition(
ROOT_ID,
{
kind: 'begin_transfer',
kind: 'begin_handoff',
expectedRevision: claimed.record!.revision,
transactionId: 'desktop-to-cli',
from: DESKTOP,
Expand All @@ -334,12 +334,12 @@ test('persists transfer intent before cutover and commits the exact target', asy
);
assert.equal(begun.kind, 'applied');
assert.deepEqual(await readLocalHostDeploymentRecord(ROOT_ID, options), begun.record);
assert.equal(begun.record?.state.kind, 'transferring');
assert.equal(begun.record?.state.kind, 'handoff');

const committed = await applyLocalHostDeploymentTransition(
ROOT_ID,
{
kind: 'commit_transfer',
kind: 'commit_handoff',
expectedRevision: begun.record!.revision,
transactionId: 'desktop-to-cli',
to: CLI,
Expand All @@ -358,7 +358,7 @@ test('persists transfer intent before cutover and commits the exact target', asy
const retried = await applyLocalHostDeploymentTransition(
ROOT_ID,
{
kind: 'commit_transfer',
kind: 'commit_handoff',
expectedRevision: begun.record!.revision,
transactionId: 'desktop-to-cli',
to: CLI,
Expand All @@ -377,26 +377,27 @@ test('rejects stale confirmation after the owner revision changes', async (t) =>
options,
);
assert.equal(claimed.kind, 'applied');
const selected = await applyLocalHostDeploymentTransition(
const released = await applyLocalHostDeploymentTransition(
ROOT_ID,
{
kind: 'select',
kind: 'release',
expectedRevision: claimed.record!.revision,
owner: DESKTOP,
selected: {
...DESKTOP_DEPLOYMENT,
version: '1.1.0',
integrity: CLI_DEPLOYMENT.integrity,
},
},
options,
);
assert.equal(selected.kind, 'applied');
assert.equal(released.kind, 'applied');
const reclaimed = await applyLocalHostDeploymentTransition(
ROOT_ID,
{ kind: 'claim', owner: DESKTOP, selected: DESKTOP_DEPLOYMENT },
options,
);
assert.equal(reclaimed.kind, 'applied');

const stale = await applyLocalHostDeploymentTransition(
ROOT_ID,
{
kind: 'begin_transfer',
kind: 'begin_handoff',
expectedRevision: claimed.record!.revision,
transactionId: 'stale-prompt',
from: DESKTOP,
Expand All @@ -417,7 +418,7 @@ test('rejects stale confirmation after the owner revision changes', async (t) =>
);
});

test('rolls an interrupted transfer back to the exact previous owner state', async (t) => {
test('rolls an interrupted handoff back to the exact previous owner state', async (t) => {
const options = await authority(t);
const claimed = await applyLocalHostDeploymentTransition(
ROOT_ID,
Expand All @@ -427,7 +428,7 @@ test('rolls an interrupted transfer back to the exact previous owner state', asy
const begun = await applyLocalHostDeploymentTransition(
ROOT_ID,
{
kind: 'begin_transfer',
kind: 'begin_handoff',
expectedRevision: claimed.record!.revision,
transactionId: 'recover-me',
from: DESKTOP,
Expand All @@ -439,7 +440,7 @@ test('rolls an interrupted transfer back to the exact previous owner state', asy
const rolledBack = await applyLocalHostDeploymentTransition(
ROOT_ID,
{
kind: 'rollback_transfer',
kind: 'rollback_handoff',
expectedRevision: begun.record!.revision,
transactionId: 'recover-me',
from: DESKTOP,
Expand All @@ -455,13 +456,15 @@ test('rolls an interrupted transfer back to the exact previous owner state', asy
selected: DESKTOP_DEPLOYMENT,
});

const changedSelection = await applyLocalHostDeploymentTransition(
const changedHandoff = await applyLocalHostDeploymentTransition(
ROOT_ID,
{
kind: 'select',
kind: 'begin_handoff',
expectedRevision: rolledBack.record!.revision,
owner: DESKTOP,
selected: {
transactionId: 'replacement',
from: DESKTOP,
to: DESKTOP,
target: {
...DESKTOP_DEPLOYMENT,
version: '1.1.0',
integrity: CLI_DEPLOYMENT.integrity,
Expand All @@ -472,17 +475,57 @@ test('rolls an interrupted transfer back to the exact previous owner state', asy
const staleRetry = await applyLocalHostDeploymentTransition(
ROOT_ID,
{
kind: 'rollback_transfer',
kind: 'rollback_handoff',
expectedRevision: begun.record!.revision,
transactionId: 'recover-me',
from: DESKTOP,
selected: DESKTOP_DEPLOYMENT,
},
options,
);
assert.equal(changedSelection.kind, 'applied');
assert.equal(changedHandoff.kind, 'applied');
assert.equal(staleRetry.kind, 'rejected');
assert.equal(staleRetry.kind === 'rejected' ? staleRetry.reason : undefined, 'transfer_changed');
assert.equal(staleRetry.kind === 'rejected' ? staleRetry.reason : undefined, 'handoff_changed');
});

test('uses the same durable handoff for an owner-preserving deployment replacement', async (t) => {
const options = await authority(t);
const claimed = await applyLocalHostDeploymentTransition(
ROOT_ID,
{ kind: 'claim', owner: CLI, selected: DESKTOP_DEPLOYMENT },
options,
);
const begun = await applyLocalHostDeploymentTransition(
ROOT_ID,
{
kind: 'begin_handoff',
expectedRevision: claimed.record!.revision,
transactionId: 'cli-upgrade',
from: CLI,
to: CLI,
target: CLI_DEPLOYMENT,
},
options,
);
const committed = await applyLocalHostDeploymentTransition(
ROOT_ID,
{
kind: 'commit_handoff',
expectedRevision: begun.record!.revision,
transactionId: 'cli-upgrade',
to: CLI,
target: CLI_DEPLOYMENT,
},
options,
);

assert.equal(committed.kind, 'applied');
assert.deepEqual(committed.record?.state, {
kind: 'owned',
owner: CLI,
selected: CLI_DEPLOYMENT,
previous: DESKTOP_DEPLOYMENT,
});
});

test('requires exact owner and revision before releasing durable authority', async (t) => {
Expand Down
Loading