fix(desktop): hide collapsed sidebar icon rail - #3808
Open
ButterBright wants to merge 1 commit into
Open
Conversation
Astro-Han
reviewed
Aug 25, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Update on 1ffbc27c87:
Standards NO-GO (5 hard): missing real-window smoke (smoke:real-window), incomplete before/after evidence, missing AI-use declaration, incomplete PR template/branch naming. Code itself is Spec PASS — collapsed rail correctly hidden via visibility:hidden with restore action. CI test is still QUEUED — not green.
简体中文
因流程与验证材料缺失暂不通过。
Member
Author
|
Updated. |
Contributor
|
Thanks, nice fix~ The e2e might need some fix since it changes the folding action. Can we take a look at the e2e test and fix these? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the macOS traffic-light buttons so they no longer span the sidebar and main content area.
When collapsed, the sidebar now:
Verification
Added Playwright coverage confirming that:
0px.AI use
Select exactly one:
Tool(s) and scope:
Investigated the collapsed-sidebar layout, implemented the CSS and Storybook updates, added targeted Playwright coverage.
Checklist
Does this PR entail a change in behavior?