fix(desktop): make recovery notice non-blocking - #3805
Open
M4n5ter wants to merge 1 commit into
Open
Conversation
Start Runtime Host and the Renderer before presenting prior-run recovery evidence. Acknowledge that evidence when the live Renderer receives a compact toast, while keeping its bounded diagnostics copyable for the rest of the process. Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
English
The previous-session recovery dialog ran before Runtime Host boot. Restarting while it was open therefore left another unclean-run record and could repeat the same blocking dialog indefinitely.
This change starts Desktop normally, then presents the retained evidence as a compact, localized Toast. The live Renderer acknowledges the notice once while the original bounded diagnostic evidence remains copyable for the rest of that process. Current-startup fatal errors remain native and blocking.
简体中文
原有的上次运行恢复弹窗会在 Runtime Host 启动前显示。在弹窗打开时再次重启会留下另一条未正常退出记录,导致同一个阻塞弹窗可能无限重复。
本改动让 Desktop 先正常启动,再用紧凑且本地化的 Toast 展示已保留的证据。可用 Renderer 只确认一次提示,同时原有的有界诊断证据在本次进程中仍可复制。当前启动本身发生 fatal error 时仍使用原生阻塞错误。
Fixes #3804
Verification
English
npm run buildnpm run typechecknpm run lintnpm run format:checknpm run devflow on macOS: force-terminated one run, verified the next run opened before showing the localized Toast, verified the pending record was acknowledged, then quit normally and verified a further launch showed no stale notice简体中文
npm run buildnpm run typechecknpm run lintnpm run format:checknpm run dev流程:强制终止一次运行,验证下一次先进入 Desktop 再显示本地化 Toast、pending 记录被确认;随后正常退出并验证再次启动不会显示旧提示AI use
Tool(s) and scope: OpenAI Codex assisted with diagnosis, implementation, tests, and development-path UI validation under the contributor's direction.
Checklist
Does this PR entail a change in behavior?