Skip to content

fix(desktop): hide single Host settings selector #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
M4n5ter merged 2 commits into from
Aug 25, 2026
+2 −2
Merged

fix(desktop): hide single Host settings selector #3799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e6e888
fix(desktop): hide single Host settings selector
M4n5ter Aug 25, 2026
475f72a
test(desktop): await multi-Host settings selector
M4n5ter Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/renderer/settings/settings-surface.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,7 @@ export function SettingsSurface(props: {
<p className="settingsPageHeaderDescription">{headerCopy.description}</p>
)}
</div>
{showsRuntimeHost && runtimeHostOptions.length > 0 ? (
{showsRuntimeHost && runtimeHostOptions.length > 1 ? (
<div className="settingsRuntimeHostSelector">
<Selector
label={copy.runtimeHost}
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/stories/settings/settings-pages.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2205,7 +2205,7 @@ export const ModelsConnectionsHostGenerationRevalidation: Story = {
isDefault: true,
});

await userEvent.click(canvas.getByRole('combobox', { name: 'Runtime Host' }));
await userEvent.click(await canvas.findByRole('combobox', { name: 'Runtime Host' }));
await within(document.body).findByRole('option', { name: 'Remote' });
await userEvent.keyboard('{Escape}');
await expect(boundary).toHaveAttribute('inert');
Expand Down