fix(ui): settle live turn after persisted completion - #3791
Merged
hqhq1025 merged 1 commit intoAug 25, 2026
Conversation
Astro-Han
reviewed
Aug 25, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
I reviewed this head and found no blocking issues.
reconcileTerminalLiveTurn() now correctly uses the persisted non-running turn_state for the same turnId as terminal evidence, clearing stale retry and marking in-flight tools as interrupted. No parallel authority or inferred state misuse.
No P0-P3. Checks on 6bce1b5ddb are test: in_progress — code GO, awaiting green.
简体中文
该头未发现阻断。Generated-by: OpenAI Codex
hqhq1025
force-pushed
the
codex/fix-stale-live-turn-terminal
branch
from
August 25, 2026 13:15
6bce1b5 to
34d49b0
Compare
Contributor
Author
|
Rebased onto current Local verification on
Please re-review the refreshed head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turn_stateas authoritative terminal evidence when the renderer missed the live terminal eventRoot cause
The Runtime Host had completed the run and persisted both the assistant response and terminal
turn_state, butreconcileTerminalLiveTurn()only used the persisted terminal marker to settle steering messages. A live projection containing text was retained unchanged, so a missed terminal event could leave the renderer permanently active even though the answer was already visible.Verification
npm --workspace @maka/ui test— 228/228 passednpx biome check packages/ui/src/live-turn-projection.ts packages/ui/src/__tests__/live-turn-projection.test.ts packages/runtime-host/src/__tests__/execution-host-queue.test.ts— passednpm --workspace @maka/ui run typecheck— passednpm --workspace @maka/runtime-host run typecheck— passednpm --workspace @maka/desktop run typecheck— passedgit diff --check origin/main...HEAD— passedThe full Runtime Host suite was attempted, but current-main integration fixtures fail during Host startup with
no such table: message_admissionsand then do not exit cleanly. The Runtime Host build and typecheck pass; the failure occurs before the changed queue assertions execute.AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex investigated the runtime/renderer state mismatch, implemented the reconciliation fallback, added regression coverage, and performed local verification.
Checklist
Does this PR entail a change in behavior?