Skip to content

fix(desktop): clip sidebar overflow during expansion - #3779

Merged
Astro-Han merged 1 commit into
apache:mainfrom
saltand:fix/sidebar-settings-transition
Aug 25, 2026
Merged

fix(desktop): clip sidebar overflow during expansion#3779
Astro-Han merged 1 commit into
apache:mainfrom
saltand:fix/sidebar-settings-transition

Conversation

@saltand

@saltand saltand commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Prevent the sidebar's expanded content from briefly creating a horizontal
scrollbar while the sidebar width transition catches up.

Verification

  • npx biome check apps/desktop/src/renderer/styles/shell-layout.css
  • npm --workspace @maka/desktop run typecheck

Before

recording_2026-08-25_17-11-23.mp4

After

recording_2026-08-25_17-04-11.mp4

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:
Codex assisted with diagnosing the transient overflow and implementing the CSS fix.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this head and found no blocking issues.

The change is 2 lines in shell-layout.css (overflow: clip on the width authority) for the sidebar motion. No overlay/clip regression, and the typecheck/build blocks are baseline mismatches unrelated to this change.

No P0-P3.

简体中文该头未发现阻断。

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — 5ce136c, no P0-P3, CSS clip correctly scoped.

@Astro-Han
Astro-Han merged commit c78f850 into apache:main Aug 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants