Skip to content

chore(deps): bump Astryx core to 0.5.0 - #3755

Open
testikun wants to merge 4 commits into
apache:mainfrom
testikun:codex/issue-3753-astryx-core-050
Open

chore(deps): bump Astryx core to 0.5.0#3755
testikun wants to merge 4 commits into
apache:mainfrom
testikun:codex/issue-3753-astryx-core-050

Conversation

@testikun

@testikun testikun commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade @astryxdesign/core from 0.4.5 to 0.5.0 across the root, UI, and Desktop packages.
  • Upgrade @astryxdesign/theme-neutral to 0.5.0 so its strict peer dependency matches the new core version.
  • Regenerate the versioned patch-package patch as @astryxdesign/core@0.5.0.
  • Drop the two patch hunks now provided upstream (Kbd.js and useHotkeys.js).
  • Update third-party notices and patch documentation.

Fixes #3753

Verification

  • Clean npm ci applies the 0.5.0 patch successfully.
  • @maka/ui tests: 227 passed.
  • Desktop typecheck passed.
  • Desktop main-process tests: 1,475 passed.
  • npm run format:check passed.
  • npm run lint passed.
  • npm run check:third-party-notices passed.
  • npm run check:stale passed.
  • Desktop build passed.

Manual CJK IME interaction was not run in the automated environment; the affected UI package and Desktop suites pass.

简体中文摘要

本 PR 将 @astryxdesign/core 从 0.4.5 升级到 0.5.0,并同步升级具有严格 peer 依赖的 theme-neutral。重新生成了 0.5.0 版本 patch,删除已经被上游吸收的 Kbd.jsuseHotkeys.js 两个 hunk,同时更新 lockfile、许可证清单和 patch 文档。

干净安装、UI 测试、Desktop 类型检查、Desktop 主进程测试、构建、lint、format 和 stale/许可证检查均已通过。

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex assisted with the dependency-upgrade analysis, patch regeneration, affected-file updates, regression verification, and PR preparation. The commit includes the Generated-by: OpenAI Codex trailer; the human contributor remains responsible for review and submission.

@Astro-Han

Copy link
Copy Markdown
Contributor

Hi, Could you include the tools used in the commit?

@Astro-Han

Copy link
Copy Markdown
Contributor

Also CI need fixing.

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this head and found no blocking issues.

The bump to Astryx 0.5.0 correctly converges the two upstream-absorbed hunks and regenerates the remaining 5 hunks against the new dist, with THIRD_PARTY_NOTICES in sync. No new business logic.

Minor note: patch still carries 5 hunks (+36/-71 net reduction) — a maintained holding cost to be re-checked on next upstream bump (already documented).

No P0-P2.

简体中文该头未发现阻断,剩余补丁持有成本可接受。

@testikun
testikun force-pushed the codex/issue-3753-astryx-core-050 branch from 1217e55 to 1174414 Compare August 25, 2026 05:18
Generated-by: OpenAI Codex
@testikun
testikun force-pushed the codex/issue-3753-astryx-core-050 branch from 1174414 to 26b5365 Compare August 25, 2026 05:23

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this rebased head.

The only change vs 11744146 is a LICENSE line updating the patch filename to 0.5.0.patch, matching the prior patch rename. No runtime changes beyond the previously reviewed Astryx 0.5.0 convergence. Previous P3 holding-cost note remains.

No P0-P2.

简体中文该头为 LICENSE 同步重整,无新增阻断。

@Astro-Han

Copy link
Copy Markdown
Contributor

Got a CI error need fixing:
Error: Generated Astryx theme is stale: maka.css, maka.js. Run "npm run astryx:theme" and commit the result.

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on cd90e76d07:

Only astryx-theme/maka.{css,js} refreshed vs 26b5365. No runtime changes beyond prior Astryx convergence.

No P0-P2.

简体中文该头为主题产物刷新,无新增阻断。

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on 30d55520b4:

Only aria-current="page""true" test sync vs cd90e76d. No runtime changes beyond prior Astryx convergence.

No P0-P2.

简体中文该头为测试断言同步,无新增阻断。

@testikun

Copy link
Copy Markdown
Contributor Author

Follow-up fix pushed in 4340c6669.

Astryx 0.5.0 no longer exposed the nested DialogHeader title as the native dialog accessible name in the Storybook smoke environment. RemoteProjectDirectoryDialog now supplies an explicit aria-label using the same localized title, keeping the production dialog named across Astryx versions.

Local verification: Storybook build plus all 194 Storybook smoke stories pass; repository typecheck, format check, and lint pass. The Windows release check also passes on the new head.

简体中文 为远程项目目录对话框增加显式 aria-label,修复 Astryx 0.5.0 下 Storybook 无障碍审计找不到 Build Host 对话框名称的问题。

Generated-by: OpenAI Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(deps): bump @astryxdesign/core to 0.5.0 and rebuild the patch

2 participants