fix(desktop): recover stale transcript subscriptions - #3754
Merged
Astro-Han merged 1 commit intoAug 25, 2026
Conversation
Astro-Han
reviewed
Aug 25, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
I reviewed this head and found no blocking issues.
The fix correctly narrows the not_found predicate to only operation=session.transcript.page — the sole exact pair emitted when an active transcript subscription is reaped. Other not_found failures remain terminal. The linearisation (detach/close failed attempt, open new subscription, recover via snapshot/projector reconcile) is sound, and the new test covers the page-not-found window without requiring renderer resubscribe.
Checks on 97105e7d3c are test: in_progress — code is GO.
简体中文
该头未发现阻断。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.transcript.page+not_foundas a recoverable subscription failure.not_foundoperations andsession_removedterminal.Fixes #3748
Verification
简体中文摘要
当旧 Session subscription 在 transcript 分页期间失效时,Runtime Host 返回的是
RuntimeHostOperationError("session.transcript.page", "not_found")。Desktop 之前没有把它识别为可恢复错误,导致后台任务继续运行但界面停止接收实时更新。本 PR 只放行这一组精确错误,复用现有的重新订阅、snapshot/transcript reconcile 和后续 frame 处理流程;其他
not_found和session_removed行为保持不变,并增加确定性回归测试。