Skip to content

fix(bitbucket): normalize issue comment deleted flag#895

Open
KatalKavya96 wants to merge 1 commit into
apache:mainfrom
KatalKavya96:fix-bitbucket-issue-comment-deleted-flag
Open

fix(bitbucket): normalize issue comment deleted flag#895
KatalKavya96 wants to merge 1 commit into
apache:mainfrom
KatalKavya96:fix-bitbucket-issue-comment-deleted-flag

Conversation

@KatalKavya96

Copy link
Copy Markdown
Contributor

Summary

Type of change

  • Python package (tools/*/ with pyproject.toml)

Test plan

  • PYTHONPATH=src uv run --group dev pytest tests/test_bitbucket.py -q -k "issue_comments or issue_comment"
  • PYTHONPATH=src uv run --group dev pytest tests/test_bitbucket.py -q
  • uv run --group dev ruff check src tests --fix
  • uv run --group dev ruff format src tests
  • uv run --group dev mypy src tests
  • git diff --check

Linked issues

Refs #606

@KatalKavya96

Copy link
Copy Markdown
Contributor Author

Hi @potiuk, I opened a small follow-up from your #864 nit.

This normalizes Cloud issue comment deleted through _bool_or_none() for consistency with PR discussion comments and adds a small test.

Targeted pytest, full Bitbucket pytest, ruff, mypy, and git diff --check are passing.

@KatalKavya96

Copy link
Copy Markdown
Contributor Author

Thanks for the review and approval @potiuk. Could you please merge this one when you get a chance, so I can move ahead with the next Bitbucket follow-up for #606?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants