KAFKA-20902: Fix oldest-iterator-open-since-ms for same-ms iterators - #23126
Open
sumanpal97 wants to merge 1 commit into
Open
KAFKA-20902: Fix oldest-iterator-open-since-ms for same-ms iterators#23126sumanpal97 wants to merge 1 commit into
sumanpal97 wants to merge 1 commit into
Conversation
Make the openIterators comparator total by tie-breaking on a per-iterator sequence id, so iterators opened in the same millisecond are tracked uniquely in metered store wrappers. Add regression tests for same-ms iterator tracking. Signed-off-by: sumanpal97 <sumanpal198@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openIteratorscomparator total by tie-breaking on a per-iterator sequence id, so iterators opened in the same millisecond are tracked uniquely in metered store wrappers.openIteratorsset.Fixes KAFKA-20902.
Test plan
./gradlew :streams:build(compile, checkstyle, all streams unit tests)New regression tests fail without the fix and pass with it:
MeteredKeyValueStoreTest.shouldTrackOldestOpenIteratorWhenTwoOpenedInSameMillisecondMeteredKeyValueStoreTest.shouldTrackOldestOpenIteratorWhenYoungerIteratorInSameMillisecondIsClosedFirstMeteredWindowStoreTest.shouldTrackOldestOpenIteratorWhenDifferentIteratorTypesOpenedInSameMillisecondReviewers: @aliehsaeedii (flagged the issue in MINOR: De-duplicate Metered*WithHeaders read-only-record iterators #22975)