MINOR: Bump trunk to 4.5.0-SNAPSHOT - #23125
Conversation
| branches: | ||
| - 'trunk' | ||
| - '4.3' | ||
| - '4.4' |
There was a problem hiding this comment.
I'm wondering whether the active branches 4.3 and 4.2 should be included
There was a problem hiding this comment.
Thanks for reviewing!
Yes. I checked the current supported releases and recent branch activity, and both 4.3 and 4.2 are still active maintenance branches.
I’ll include them in both push and pull_request so this workflow also runs for PRs and pushes targeting those branches.
|
I think we need to update |
Thanks for reviewing and pointing out. I updated Since |
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Thanks for the update. A bunch of tests will need tweaking I think.
| // | ||
|
|
||
| // New version for the Kafka 4.5.0 release. | ||
| IBP_4_5_IV0(34, "4.5", "IV0", false); |
There was a problem hiding this comment.
I don't think you need to add this one yet, just moving the comment tells the next MV author where to insert their new MV.
There was a problem hiding this comment.
Thanks, that makes sense. I originally added IBP_4_5_IV0 to keep the existing latestTesting() > LATEST_PRODUCTION invariant used by some tests. I removed it now and kept the unstable-version boundary comment after IBP_4_4_IV2 instead.
I also updated the affected tests to handle the temporary state where latestTesting() can equal LATEST_PRODUCTION.
MetadataVersionTest still verifies that latestTesting is unstable when it is newer than LATEST_PRODUCTION, and FormatterTest now skips unstable-release-version cases when no unstable MV exists. I also updated the expected share.version default to SV_2 since LATEST_PRODUCTION is now 4.4-IV2.
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the PR.
As described in
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=34840886#ReleaseProcess-CutBranches
This is the standard post-branch-cut bump after the 4.4 branch was
created. Trunk now tracks 4.5.0-SNAPSHOT.
Reviewers: Chia-Ping Tsai chia7712@gmail.com, Andrew Schofield
aschofield@confluent.io