KAFKA-20187: Fix for AsyncKafkaConsumer not clearing endOffsetRequested flag - #23123
Merged
Conversation
AndrewJSchofield
requested changes
Aug 12, 2026
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. Overall, looks good. A few minor comments to address.
| if (subscriptionState.partitionEndOffset(topicPartition, isolationLevel) == null && | ||
| offsetFetcherUtils.maybeSetPartitionEndOffsetRequest(topicPartition)) { | ||
|
|
||
| Map<TopicPartition, Long> timestampToSearch = Collections.singletonMap( |
Member
There was a problem hiding this comment.
Map.of(_,_) is preferred nowadays.
| boolean requireTimestamps, | ||
| boolean oneShot) { | ||
| if (timestampsToSearch.isEmpty()) { | ||
| return CompletableFuture.completedFuture(Collections.emptyMap()); |
Member
There was a problem hiding this comment.
I know this is not the changed code, but we prefer Map.of() nowadays.
| consumer.poll(Duration.ofMillis(0)); | ||
| } | ||
|
|
||
| // Since the AsyncConsumer uses a background thread, add this barrier here |
Member
There was a problem hiding this comment.
Strictly speaking, adding this wait is just aligning this test with the others so this comment is a bit out of place. I would remove the comment for consistency.
AndrewJSchofield
approved these changes
Aug 13, 2026
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. I particularly like how three of the KafkaConsumerTest test cases now apply to modern consumer groups too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue for the AsyncKafkaConsumer where the endOffsetRequested
flag is not cleared on failed LIST_OFFSETS calls.
Reviewers: Andrew Schofield aschofield@confluent.io