KAFKA-20790: adding assignor broker side validation - #23121
Open
gabriellefu wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
triage
Move the streams.assignor.name registry check from the active controller to the broker that receives the IncrementalAlterConfigs request. The assignors are registered on brokers, which are the nodes that run the group coordinator, so the controller was validating a group's selection against its own group.streams.assignors. KIP-1357 states that the check relies on "all brokers having the same group.streams.assignors configuration" - controllers are not brokers, so the implementation silently required controller nodes to carry a broker-side plugin config and the custom assignor classes on their classpath. A controller-only node left unconfigured rejected every custom assignor name, while DescribeConfigs, which is served by a broker, reported that same name as the group's effective assignor. - GroupConfig.validateAssignorName is extracted from validateValues so that it can be called with just a name and the registered names. It trims its input because it now runs before ConfigDef parses the value. - ConfigAdminManager.preprocess checks SET operations on streams.assignor.name and rejects them with INVALID_CONFIG, so an unregistered name is never forwarded to the controller. - ControllerConfigurationValidator no longer consults the assignor registry. It keeps validating the remaining group configs, which need the merged post-operation view that only the controller has. The runtime fallback in GroupMetadataManager is unchanged and remains the safety net for a name that is not available on the coordinator's broker. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gabriellefu
force-pushed
the
broker_validation
branch
from
August 10, 2026 22:09
50657fc to
ffc6cf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change the assignor name validation from controller to the broker side