KAFKA-20684 [1/N]: Remove test SubscriptionState subscribe overload - #23102
Merged
chia7712 merged 4 commits intoAug 11, 2026
Conversation
…oads Drops the three subscribe(X, Optional<ConsumerRebalanceListener>) overloads and the listener argument at all 52 call sites, all in clients/src/test.
chia7712
reviewed
Aug 11, 2026
| assertEquals(List.of("assigned-1arg", "revoked-1arg", "revoked-1arg"), calls); | ||
| } | ||
|
|
||
| private static class MockRebalanceListener implements ConsumerRebalanceListener { |
Member
There was a problem hiding this comment.
Interesting. This mock listener isn't actually being used :)
chia7712
pushed a commit
that referenced
this pull request
Aug 11, 2026
…23102) Drops the three subscribe(..., Optional<ConsumerRebalanceListener>) overloads and the listener argument at all 52 call sites, all in clients/src/test. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the three subscribe(..., Optional)
overloads and the listener argument at all 52 call sites, all in
clients/src/test.
Reviewers: Chia-Ping Tsai chia7712@gmail.com