Repository navigation
JSPWIKI-1296 see jira for details - #528
spyhunter99 wants to merge 2 commits into
Conversation
| * @param attributes the final attribute set of the node, mutated in place | ||
| */ | ||
| static void sanitize(final Node node, final AttributablePart part, final MutableAttributes attributes) { | ||
| for (final String name : new ArrayList<>(attributes.keySet())) { |
There was a problem hiding this comment.
there's a property to enable unsafe html that would've to be checked here, but otherwise than that it's a lgtm for me
There was a problem hiding this comment.
i looked into this, not clear how to get access to the wiki properties, engine or context from this class. any ideas?
There was a problem hiding this comment.
In MarkdownForJSPWikiExtension f.ex., Context is passed through the constructor, which is passed on MarkdownDocument#options, which comes from MarkdownRenderer, from both constructor and getString method. The create constructor for the extensions seems more a convention inside Flexmark than anything else, it works fine if you pass the Context there (not sure if explaining myself clearly.. a bit late here)
| */ | ||
| @Override | ||
| public void rendererOptions(final MutableDataHolder options) { | ||
| escapeHtml = HtmlRenderer.ESCAPE_HTML.get(options); |
There was a problem hiding this comment.
Not what I had in mind, but definitely better!
2 participants
No description provided.